Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Cleanup travis configuration for old artifcats #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthiasbeyer
Copy link

No description provided.

Copy link
Member

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend checking out my travis config over at
https://github.com/epage/status/blob/master/.travis.yml

script:
- rustup component add clippy-preview
- cargo clippy -- -D warnings
- rust: 1.27.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The advantage of pinning the version for rustfmt is your CI won't break when a new version of Rust is out that tweaks the format.

script:
- cargo fmt --all -- --write-mode=diff
- cargo build --all --all-features
- cargo test --all --all-features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to drop clippy?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but only temporarily until I figured out what to do with the codebase (maybe a big"ish" refactoring).


script:
- cargo fmt --all -- --write-mode=diff
- cargo build --all --all-features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you could just run cargo check

- cargo fmt --all -- --write-mode=diff

script:
- cargo fmt --all -- --write-mode=diff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides not pinning rustfmt, a disadvantage of running it in the regular job is that it will be duplicated per environment which I doubt you need.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants