Targeted lighting #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
cjdb
commented
Mar 11, 2018
cjdb
commented
- Added directional lighting (closes Add directional lights #21)
- Added point (positional) lighting (closes Add point lights #22)
- Added spot lighting (closes Add spotlights #23)
…uctor so that it does not throw when constructed as a part of a composite type.
Qualified Regular as ranges::Regular. Closes #56.
cjdb
added a commit
that referenced
this pull request
Mar 31, 2018
* Added uniform testing * Changes to compound-assignment operators and began to clean up tests * Refined tests * Added tests for uniform<i?vec2>, made it possible for uniform<[iu]?vec\d> to exist, added type traits and tests for type traits * Added support for [iu]?vec[34] and tests * Added final tests for uniform 0.5 * Migrating examples to use uniform 0.5 * Examples moved to uniform 0.5 * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * Added initial TravisCI YAML script * README: Fix typing error This patch fixes a typo of the word `by` as the word `my` in the project README file. * Added utility functions and an error type. Corrected uniform's constructor so that it does not throw when constructed as a part of a composite type. * Not sure what this is about (#17) * Deleted .travis.yml, as it's not relevant to this branch. * Added newline to end of file. * Targeted lighting (#51) * Added light source code * Added improved diagnostics * Added directional light type. In the process of making a point light type. * Added point-light example code starting point. * Added utility functions and an error type. Corrected uniform's constructor so that it does not throw when constructed as a part of a composite type. * Added directional light example, introduced new headers * Preparing for point_light * Got point light working with specular lighting * Made changes to cube, these needed to be reflected in example.directional_light * Forgot to commit light_source * Major rewrite for lighting * Added spot light * Removed older lighting example * Forgot to remove old lighting compilation from CMakeLists * Changed basic_angle::operator+() and basic_angle::operator-() to be const. Closes #54 (#55) * Qualified Regular as ranges::Regular (#57) Qualified Regular as ranges::Regular. Closes #56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.