Notice fixes for when mailing key does not exist

[eileenmcnaughton]

These were picked up from the civi log but would relate to the different statuses the mailing might have

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[demeritcowboy]

Having trouble with this one:
(a) I don't see how these warnings can come up. The whole point of this page is to display report.mailing so it can't really be missing. Even if it's just scheduled but not sent, the var is still there.
(b) You've indicated they're in civi log but typically smarty warnings about missing vars aren't in the log - only if it's a crash.
(c) I do see warnings about $group.mailing, but that's a different var not covered in this PR. Similarly I see one about campaign (since I don't happen to have campaigns where I'm looking).

[eileenmcnaughton]

@demeritcowboy - this covers the Campaign one #31654

I guess the notice I was seeing in the logs could be group.mailing not just plain mailing - there is soooo much noise from these smarty notices in the php log it's hard to know - because I seem to be be looking at a backtrace for each one with a lot of scrolling.... I suspect what might be happening is that actually an invalid mailing_id is being hit in the url - so the php log is getting filled with noise - but nothing usable is rendered

[colemanw]

@eileenmcnaughton this has a merge-conflict

[demeritcowboy]

I don't think this should be merged. It's the wrong "mailing" var in my opinion.

[colemanw]

Ok let's close it for now.