Drops PG14 support #7753
Merged
Drops PG14 support #7753
+63
−32,875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naisila
force-pushed
the
naisila/drop_pg14
branch
from
7a04b5c to
b5ffa71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7753 +/- ##
================================================
- Coverage 89.48% 89.46% -0.03%
================================================
Files 276 276
Lines 60063 59892 -171
Branches 7524 7510 -14
================================================
- Hits 53747 53580 -167
- Misses 4166 4167 +1
+ Partials 2150 2145 -5 |
naisila
force-pushed
the
naisila/drop_pg14
branch
2 times, most recently
from
98ab8c9 to
0a49a3a
Compare
|
Code & test output changes look good to me. Will do another pass once the branch is rebased & polished and the conflicts are resolved. |
naisila
force-pushed
the
naisila/drop_pg14
branch
from
0a49a3a to
6b109e0
Compare
onurctirtir
force-pushed
the
naisila/drop_pg14
branch
2 times, most recently
from
848ba0d to
b690d1c
Compare
naisila
force-pushed
the
naisila/drop_pg14
branch
from
a83c115 to
1f2da8a
Compare
onurctirtir
approved these changes
Feb 3, 2025
| @@ -1290,7 +1286,7 @@ static DistributeObjectOps View_Rename = { | |||
| static DistributeObjectOps Trigger_Rename = { | |||
| .deparse = NULL, | |||
| .qualify = NULL, | |||
| .preprocess = PreprocessAlterTriggerRenameStmt, | |||
| .preprocess = NULL, | |||
There was a problem hiding this comment.
bc we're removing PreprocessAlterTriggerRenameStmt, nvm
| @@ -3011,7 +2969,6 @@ SyncNodeMetadataToNodesMain(Datum main_arg) | |||
|
|
|||
| PopActiveSnapshot(); | |||
| CommitTransactionCommand(); | |||
| ProcessCompletedNotifies(); | |||
There was a problem hiding this comment.
bc it was a noop for pg >= 15
- Remove "$version_num" != 'xx' from configure file - delete all PG_VERSION_NUM = PG_VERSION_XX references in the code - Look at pg_version_compat.h file, remove all _compat functions etc defined specifically for PGXX differences - delete all PG_VERSION_NUM >= PG_VERSION_(XX+1), PG_VERSION_NUM < PG_VERSION_(XX+1) ifs in the codebase - delete ruleutils_xx.c file
naisila
force-pushed
the
naisila/drop_pg14
branch
from
19deb09 to
4c6ecd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Drops PG14 support