[REVIEW, DO NOT MERGE] WebScience Migration Review #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving page management primarily to the content script environment means we don't need to track window type in the background script environment. Content scripts will only attach in ordinary web content windows.
We haven't had a compelling use case for this functionality, becuase it's generally OK for study logic to ignore pages that are already open when the extension launches. This functionality can also introduce inconsistencies for page measurements.
This functionality is no longer needed, because we can access the page privacy state in the content script environment.
We don't need to store tab information in the background script environment anymore, because we track page information in the content script environment.
We now handle these events in the content script environment.
Replacing tabs.onUpdated with webNavigation.onHistoryStateUpdated to detect History API URL changes, since the former cannot distinguish those changes from ordinary navigation URL changes. This update avoids unnecessary messages to the PageManager content script that can clutter the console.
jonathanmayer
commented
May 31, 2021
updatedSchema.schema.json
Outdated
| "$schema": "http://json-schema.org/draft-04/schema#", | ||
| "type": "object", | ||
| "mozPipelineMetadata": { | ||
| "bq_metadata_format": "pioneer", |
| "newsAndDisinfo.version": { "type": "string" }, | ||
| "newsAndDisinfo.pageNavigation": { | ||
| "type": "object", | ||
| "properties": { |
There was a problem hiding this comment.
Descriptions in here would be helpful.
jonathanmayer
commented
Jun 2, 2021
The `browserConsole` option causes a flood of errors whenever the extension code tries to access the console (e.g. `console.log`), and I couldn't find documentation for it, so I removed it. The appropriate console for the extension still opens.
rhelmer
reviewed
Jun 4, 2021
|
|
||
| "browser_specific_settings": { | ||
| "gecko": { | ||
| "id": "[email protected]", | ||
| "strict_min_version": "60.0" | ||
| "id": "[email protected]", |
There was a problem hiding this comment.
The add-ons team has asked us to change these to end with @rally.mozilla.org, could we use [email protected]?
…ageNav presence counts
…udy into ws-migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.