Fix CI #428
Merged
Fix CI #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI seemed to be broken on main for a couple of reasons (I'm assuming the root causes here are GH runner changes).
godependency on MacOS forboringssl.$RUNNER_TEMPenvironment variable not being present. Using the context variable directly is a bit more verbose but works and also won't silently expand to nothing (like the env variable was).I also altered the Unit Test stage to use
ctestas I didn't see a need for 2 different workflow steps for Windows vs. the unix platforms.