rtp_decoder support for MKI and RCCm3 ROC field #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from SRTP packet. Fix typo in rtp_decoder_init argument name.
|
@paulr227 are you able to elaborate on your use of rtp_decoder? I always wondered if it was actually used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MKI: support for MKI was added to libsrtp in 2.1.0, however the support wasn't extended to rtp_decder. These changes update rtp_decoder to use the srtp_unprotect_mki() and srtp_unprotect_rtcp_mki() APIs and to accept a new argument for specifying the MKI of the master key passed in the stream policy provided to libsrtp.
RCCm3: is one of the three integrity transforms specified in RFC4771 to support synchronisation of sender and receiver ROC by inclusion of the sender's ROC value in the optional authentication field at the end of the SRTP packet. RCCm3 is the only unauthenticated transform of the three, and therefore the only one that is supported without changes within libsrtp itself. A new rtp_decoder argument is introduced to specify the ROC transmission rate parameter. Any future support for RCCm1 and RCCm2 would be compatible with this argument.
New arguments introduced:
-i sets the MKI given in hexadecimal
-n RFC4771 ROC transmission rate (assumes RCCm3)