Merge some security fix from openIDC#134
Open
kunqn wants to merge 6 commits into
Open
Conversation
… octets in AES GCM decryption
by validating the encrypted_key length before AES_unwrap_key Signed-off-by: Hans Zandbelt <hans.zandbelt@openidc.com> # Conflicts: # CHANGELOG.md
… 7518 section 3.2) HMAC signing/verification accepted oct keys shorter than the hash output. RFC 7518 section 3.2 requires an HS256/384/512 key to be at least the size of the corresponding hash (32/48/64 bytes). Reject shorter keys in _cjose_jws_build_dig_hmac_sha(), which runs on both the sign and verify paths. (Port of the version-1.0.x J6 fix.) Signed-off-by: Hans Zandbelt <hans.zandbelt@openidc.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> # Conflicts: # src/jws.c
… (remote, pre-auth DoS)
kunqn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2a6e5bd: jwe: fix all-zero CEK for AES-CBC-HMAC content encryption
7325e9a: use fixed authentication tag length of 16 octets in AES GCM decryption
8c51d24: fix heap buffer overflow in AES key unwrap
0754ab9: jwe: require the RSA-decrypted CEK length to match the enc keysize (partially for jwe->cek cleanse)
cc83587: jws: enforce minimum HMAC key length (RFC 7518 section 3.2)