Skip to content

Commit

Permalink
Add TODO comment to simplify this role
Browse files Browse the repository at this point in the history
  • Loading branch information
allenrobel committed Aug 20, 2022
1 parent cc57256 commit e380b8a
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions roles/ndfc_rest_vpc_create/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
vars:
device_name: "{{ vpc_config.peer_1 }}"

# TODO: Use ndfc_device_info_get here (see ndfc_vpc_interface_config_merged)
# TODO: Use ndfc_device_info_get to retrieve serialNumber, isVpcConfigured, switchDbID (see ndfc_vpc_interface_config_merged)
# set_fact for p1_serial, p1_vpc, p1_db_id
- name: main query FABRIC {{ device_config.switch_fabric }} VPC {{ vpc_name }} vpc_peer_1 {{ device_config.ip }}
cisco.dcnm.dcnm_inventory:
Expand All @@ -41,7 +41,7 @@
vars:
device_name: "{{ vpc_config.peer_2 }}"

# TODO: Use ndfc_device_info_get here (see ndfc_vpc_interface_config_merged)
# TODO: Use ndfc_device_info_get to retrieve serialNumber, isVpcConfigured, switchDbID (see ndfc_vpc_interface_config_merged)
# set_fact for p2_serial, p2_vpc, p2_db_id
- name: main query FABRIC {{ device_config.switch_fabric }} VPC {{ vpc_name }} vpc_peer_2
cisco.dcnm.dcnm_inventory:
Expand All @@ -52,8 +52,6 @@
register: mr2
vars:
ansible_connection: httpapi
# mq5: "[?fabric == '{{ device_config.switch_fabric }}'] | [?vpc_name == '{{ vpc_name }}'].peer_2_ip | [0]"
# ip: "{{ vpc_peers | json_query(mq5)}}"

- name: main set_fact p2_serial, p2_vpc, p2_db_id
set_fact:
Expand Down

0 comments on commit e380b8a

Please sign in to comment.