-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial proposal of new api for go based gateway #1
Open
sbezverk
wants to merge
13
commits into
master
Choose a base branch
from
gateway_api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Serguei Bezverkhi <[email protected]>
ziausyed
reviewed
Jan 23, 2020
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
ziausyed
approved these changes
Jan 23, 2020
Signed-off-by: Serguei Bezverkhi <[email protected]>
ahsalam
reviewed
Jan 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Serguei,
The protobuf looks good to me.
Could you please just add more explanation to EndpointType as the difference between the three type will not be clear (at least to someone new to the project).
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Serguei Bezverkhi [email protected]
This PR proposes a new protobuf based API for the gateway. This proposal attempts to cover existing usage and in addition to offer flexibility to expand in future.
See comment in proto file for more details.