Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial proposal of new api for go based gateway #1

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

sbezverk
Copy link

Signed-off-by: Serguei Bezverkhi [email protected]

This PR proposes a new protobuf based API for the gateway. This proposal attempts to cover existing usage and in addition to offer flexibility to expand in future.
See comment in proto file for more details.

pkg/apis/gateway.proto Outdated Show resolved Hide resolved
pkg/apis/gateway.proto Outdated Show resolved Hide resolved
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Copy link

@ahsalam ahsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Serguei,
The protobuf looks good to me.
Could you please just add more explanation to EndpointType as the difference between the three type will not be clear (at least to someone new to the project).

Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Signed-off-by: Serguei Bezverkhi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants