Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing functions for nx.py class #67

Merged
merged 7 commits into from
Jul 8, 2020
Merged

Conversation

miott
Copy link
Collaborator

@miott miott commented Jul 6, 2020

When the cisco-gnmi is used by pyATS to connect to an NX device, set_json, get_xpaths, and subscribe functions are missing from the class. Those functions are very close to what exists in xe.py but with minor changes specific to NX.

@remingtonc remingtonc self-requested a review July 7, 2020 18:46
@remingtonc remingtonc added enhancement New feature or request feature labels Jul 7, 2020
Copy link
Contributor

@remingtonc remingtonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some doc clarification asks.

src/cisco_gnmi/client.py Show resolved Hide resolved
src/cisco_gnmi/nx.py Show resolved Hide resolved
src/cisco_gnmi/nx.py Outdated Show resolved Hide resolved
src/cisco_gnmi/nx.py Show resolved Hide resolved
src/cisco_gnmi/nx.py Show resolved Hide resolved
Copy link
Contributor

@remingtonc remingtonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@remingtonc remingtonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump version number.

@remingtonc remingtonc added os/nx NX-OS os/xe IOS XE labels Jul 8, 2020
Copy link
Contributor

@remingtonc remingtonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@remingtonc remingtonc merged commit 04a656b into cisco-ie:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature os/nx NX-OS os/xe IOS XE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants