Add a missing ignore for prettier #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This instructs prettier to ignore `*.lock` files since they are just JSON files and will be formatted by the pretty-format-json hook.
jsf9k
approved these changes
Feb 20, 2025
dv4harr10
approved these changes
Feb 20, 2025
mcdonnnj
added
the
kraken 🐙
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds a new glob pattern for lockfiles to the
.prettierignorefile.💭 Motivation and context
Since lockfiles are generally JSON they will already be formatted by the
pretty-format-jsonhook just like JSON files. Without this ignore we can end up with the two hooks fighting to format the file. I'm not sure how this was missed but it's giving me trouble downstream so here we are.🧪 Testing
Automated tests pass.
✅ Pre-approval checklist