Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a Molecule configuration file that is shared across scenarios #222

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Use a Molecule configuration file that is shared across scenarios #222

wants to merge 1 commit into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Feb 17, 2025

🗣 Description

This pull request:

  • Updates the code to use a Molecule configuration file that is shared across scenarios
  • Configures the Ansible roles path via the config_options parameter of the provisioner section in the shared Molecule configuration.

💭 Motivation and context

  • This DRYs out the Molecule configuration considerably for roles that have multiple Molecule scenarios.
  • This is a more direct way of setting the roles path than setting an environment variable.

🧪 Testing

All automated tests pass. I also applied these changes locally to cisagov/ansible-role-samba to verified that they functioned as expected in a multi-scenario Molecule testing configuration.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
Use a Molecule config that is shared across scenarios
c4c768e 
Also configure the Ansible roles path via the config_options parameter
of the provisioner section in the shared Molecule configuration.  This
is a more direct way of setting the roles path than settong an
environment variable.
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Feb 17, 2025
@jsf9k jsf9k marked this pull request as ready for review February 17, 2025 19:57
@jsf9k jsf9k requested a review from a team February 17, 2025 19:57
dav3r
dav3r approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

mcdonnnj
mcdonnnj approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong work 💪💪💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: In Progress
Skeleton Maintenance
Status: Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @mcdonnnj @dv4harr10