Login to Docker Hub before pulling images #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required as of Molecule 25.2.0. Also pin Molecule to 25.2.0 or greater since this is a breaking change.
jsf9k
added
improvement
We are less likely to hit rate limiting if we log into Docker Hub before pulling images.
jsf9k
force-pushed
the
improvement/use-docker-credentials-when-pulling-images
branch
from
5d1265b to
b53d129
Compare
|
This change appears to make us hit rate limiting even faster. Looking here we see that authenticated users are allowed 40 pulls per hour, while unauthenticated users are allowed 10 pulls per hour per IP. This is probably why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request modifies the
build.ymlworkflow to login to Docker Hub before performing any action that could cause Docker images to be pulled.Caution
This PR was created on top of #217 and therefore #217 must be merged before this PR.
💭 Motivation and context
This reduces the likelihood of being rate-limited when pulling Docker images from Docker Hub.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist