Disable unix-chkpwd AppArmor profile
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
bug
|
The failing tests should be fixed when ansible-community/molecule-plugins#294 is merged and a new release created. |
dav3r
approved these changes
Jan 22, 2025
6 tasks
This is necessary when running Molecule tests against Fedora 40 and 41; otherwise, the privileged container cannot successfully sudo and hence Ansible is unable to do anything. Note that this change is reverted after the Molecule tests are run. For now, disabling the unix-chkpwd AppArmor profile also requires an apt-get purge of the firefox and passt packages. It should be possible to remove this purge (and the ensuing systemctl reload apparmor.service) at a future date. See #215 for more details.
jsf9k
force-pushed
the
bugfix/disable-unix-chkpwd-apparmor-profile
branch
from
bcefbbb to
3e3ea4c
Compare
This prediction is now true! |
dv4harr10
approved these changes
Jan 23, 2025
mcdonnnj
approved these changes
Jan 23, 2025
No problem. See commit a473457. |
jsf9k
force-pushed
the
bugfix/disable-unix-chkpwd-apparmor-profile
branch
from
d62d1d0 to
8cad420
Compare
These system packages had to be uninstalled to allow the disabling of the unix-chkpwd AppArmor profile, but can be reinstalled at this point. Co-authored-by: Nicholas McDonnell <[email protected]>
jsf9k
force-pushed
the
bugfix/disable-unix-chkpwd-apparmor-profile
branch
from
8cad420 to
a473457
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request disables the
unix-chkpwdAppArmor profile before running Molecule tests against Fedora Docker containers.💭 Motivation and context
This is necessary when running Molecule tests against Fedora 40 and 41; otherwise, the privileged container cannot successfully execute
sudoand hence Ansible is unable to do anything.Note that this change is reverted after the Molecule tests are run.
For now, disabling the
unix-chkpwdAppArmor profile also requires anapt-get purgeof thefirefoxandpasstpackages. It should be possible to remove this purge (and the ensuingsystemctl reload apparmor.service) at a future date. See #215 for more details.🧪 Testing
All automated tests pass.
✅ Pre-approval checklist