Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of deprecation warnings #82

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Get rid of deprecation warnings #82

merged 3 commits into from
Feb 9, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Feb 9, 2024 •
edited
Loading

🗣 Description

This pull request makes a few modifications to Python code to get rid of some deprecation warnings. It also removes a pip package from the Dockerfile that no longer needs to be installed.

💭 Motivation and context

Getting rid of deprecation warnings means that we won't get the rug pulled out from under us later. Getting rid of unused packages leads to smaller Docker images.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

jsf9k added 3 commits February 9, 2024 09:39
@jsf9k
Bump version from 1.3.4 to 1.3.5
f77af74
@jsf9k
Prefer datetime.now(timezone.utc) to datetime.utcnow()
8010f37 
The latter is deprecated.

Note that we also remove the import of pytz from sslyze_csv2mongo.py,
since it is not being used and conflicts with the import of
datetime.timezone.
@jsf9k
Remove pytz from pip install in Dockerfile
ad7edf6 
This package is no longer being used, and in current versions of
Python its functionality resides in datetime.timezone.
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number docker Pull requests that update Docker code python Pull requests that update Python code labels Feb 9, 2024
@jsf9k jsf9k self-assigned this Feb 9, 2024
@jsf9k jsf9k marked this pull request as ready for review February 9, 2024 15:12
@jsf9k jsf9k requested a review from a team February 9, 2024 15:12
@jsf9k jsf9k enabled auto-merge February 9, 2024 15:29
michaelsaki
michaelsaki approved these changes Feb 9, 2024
View reviewed changes
Copy link

@michaelsaki michaelsaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsf9k LGTM but I was curious do version bumps normally happen prior to PR approval?

dav3r
dav3r approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k merged commit 2896383 into develop Feb 9, 2024
17 checks passed
@jsf9k jsf9k deleted the improvement/get-rid-of-deprecation-warnings branch February 9, 2024 16:48
@michaelsaki
Copy link

@jsf9k LGTM but I was curious do version bumps normally happen prior to PR approval?

Ignore this, I confused the minor bumps with finalizing bump versions

@jsf9k jsf9k mentioned this pull request Feb 23, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@michaelsaki michaelsaki michaelsaki approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
docker Pull requests that update Docker code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use python Pull requests that update Python code version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
CyHy System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @michaelsaki @dav3r @dv4harr10