Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to current-federal.csv headers with correct capitalization #80

Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 31, 2024

🗣 Description

This pull request updates references to current-federal.csv headers with correct capitalization.

💭 Motivation and context

There were some recent capitalization changes in current-federal.csv, so we should update our derivative file to match.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

…ization

There were some recent capitalization changes in
https://github.com/cisagov/dotgov-data/blob/main/current-federal.csv,
so we must update our code to match.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality version bump This issue or pull request increments the version number python Pull requests that update Python code labels Jan 31, 2024
@jsf9k jsf9k self-assigned this Jan 31, 2024
@jsf9k jsf9k removed the version bump This issue or pull request increments the version number label Jan 31, 2024
@jsf9k jsf9k marked this pull request as ready for review January 31, 2024 16:31
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@jsf9k jsf9k requested a review from a team January 31, 2024 16:53
@jsf9k jsf9k merged commit 968c56d into develop Jan 31, 2024
17 checks passed
@jsf9k jsf9k deleted the bugfix/match-current-federal-csv-header-capitalization branch January 31, 2024 17:36
jsf9k added a commit to cisagov/orchestrator that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality python Pull requests that update Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants