Upgrade to Celery 5.0 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
king-alexander
added
the
dependencies
king-alexander
requested review from
dav3r,
felddy,
jsf9k and
mcdonnnj
as code owners
dav3r
requested changes
Jun 28, 2022
There was a problem hiding this comment.
Nice work @king-alexander! I noted some minor changes that I'd like to see included here before I approve.
king-alexander
force-pushed
the
improvement/upgrade-celery
branch
2 times, most recently
from
683c4b9 to
e356a2d
Compare
dav3r
reviewed
Jun 28, 2022
mcdonnnj
requested changes
Jun 29, 2022
Celery 5.0 introduced breaking changes to the command line interface. One such change is that you can no longer pass "celery" in argv when programatically starting the celery app. This commit updates our invocation and requires Celery 5.0 (Singularity), the lowest stable version we can support with this change.
king-alexander
force-pushed
the
improvement/upgrade-celery
branch
from
782a463 to
a5df33e
Compare
Co-authored-by: Nick <[email protected]>
…alexander/admiral into improvement/upgrade-celery
king-alexander
force-pushed
the
improvement/upgrade-celery
branch
from
4208f55 to
8d0388f
Compare
dav3r
reviewed
Jun 30, 2022
The ports in use should be specified as a quoted string to avoid conflicts with YAML Base-60 floating point numbers. Co-authored-by: Nick <[email protected]>
Co-authored-by: dav3r <[email protected]>
Quotation marks around environment variables are preferred to the -/= syntax for consistency with the rest of the file. Co-authored-by: dav3r <[email protected]>
dav3r
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
I think everything looks good to me now, thank you @king-alexander for sorting all of this out! ⚓
…alexander/admiral into improvement/upgrade-celery
mcdonnnj
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Starting with version 5.0, Celery parses command line options with Click, which introduced breaking changes. I updated the call in
celery.pythat starts the app accordingly.I didn't completely avoid scope creep. In the process of upgrading, I noticed a a minor bug when the component services of admiral were starting up. Redis Commander depends upon Redis, but attempted to start first, leading to a recoverable error. This blip was corrected in
docker-compose.yml.💭 Motivation and context
This change resolves #6.
🧪 Testing
I successfully started admiral in both of its modes:
celery-shellandbash. Furthermore, all unit and system tests passed.✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Post-merge checklist