Apply New MVP+ Stylesheets (CRASM-2483) #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added main, light, dark, darker tokens to palette. - aplied design team provided colors to these tokens. - applied the tokens to the default palette colors. - added custom typography tokens to the theme. - applied design team provided styling to typography tokens. - applied design team provided styling to the following default MUI components: - Button - Chip - IconButton - Link
- Removed defaultProps settings for components. - Kept style overrides for components. - This will prevent conflicts with complex components that use base components like "Button". - i.e MUI Data Grid uses "Button" as a base component. - Added custom typography to corresponding components. - i.e "button" uses button typography.
- Created "contained" variant for buttons in Theme.tsx. - Added style overides to IconButton and Link components in Theme.tsx. - Updated Domain column in Vulnerabilities.tsx to use Link component. - Updated vulnerability title to use variant defined in Theme.tsx. - Applied IconButton to external link in DomainDetails.tsx. - Uopdated snaphots.
- Ensure components inside Theme.tsx are able to accept custom palette and typography definitions from eleswhere in the Theme object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
💭 Motivation and context
🧪 Testing
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist