Skip to content

Update fields in the frontend to match mini_dl snake case fields #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Apr 10, 2025

🗣 Description

Update the frontend to support snake_case data delivered by the backend, ensuring seamless integration and proper handling of data formatting.

💭 Motivation and context

To accurately interpret and display data delivered in snake_case format by the Python backend, so that the application works efficiently, and data integrity is maintained.
CRASM-2531

🧪 Testing

  • Ensure all relevant data processing functions in the frontend (e.g., API response handling, state management, and data binding) are updated to parse and work with snake_case attributes.
  • Update unit tests to verify that the frontend correctly processes and displays snake_case data.
  • Confirm that the updated frontend seamlessly integrates with the Python backend without any errors or data mismatches.
  • Ensure the frontend retains functionality with camelCase data in case certain backend modules still deliver data in that format during the transition period.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav added the breaking change This issue or pull request involves changes to existing functionality label Apr 10, 2025
@ameliav ameliav self-assigned this Apr 10, 2025
@rapidray12 rapidray12 merged commit c0d4788 into develop Apr 17, 2025
16 checks passed
@rapidray12 rapidray12 deleted the convert-frontend-to-use-snake-case-2531 branch April 17, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This issue or pull request involves changes to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants