Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for the use of microsoft authenticator otps #1544

Closed

Conversation

ehaines1
Copy link
Collaborator

@ehaines1 ehaines1 commented Jan 31, 2025

🗣 Description

This PR addresses a bug that existed when checking the policy 3.3 of Entra ID. We weren't checking if the Microsoft Authenticator was disabled. We also weren't checking the fields "isSoftwareOathEnabled" and the "includeTarget.id" fields of both "displayAppInformationRequiredState" and "displayLocationInformationRequiredState"

💭 Motivation and context

Closes #1484 and #1487

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@ehaines1 ehaines1 added the bug This issue or pull request addresses broken functionality label Jan 31, 2025
@ehaines1 ehaines1 added this to the Lionfish milestone Jan 31, 2025
@ehaines1 ehaines1 self-assigned this Jan 31, 2025
@ehaines1 ehaines1 closed this Feb 3, 2025
@ehaines1
Copy link
Collaborator Author

ehaines1 commented Feb 3, 2025

Replaced by #1549

@schrolla schrolla removed this from the Lionfish milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
2 participants