-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for the use of microsoft authenticator otps #1544
Closed
ehaines1
wants to merge
12
commits into
main
from
1487-check-for-the-use-of-microsoft-authenticator-otps
Closed
check for the use of microsoft authenticator otps #1544
ehaines1
wants to merge
12
commits into
main
from
1487-check-for-the-use-of-microsoft-authenticator-otps
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of https://github.com/cisagov/ScubaGear into 1487-check-for-the-use-of-microsoft-authenticator-otps
ehaines1
had a problem deploying
to
Development
January 31, 2025 16:01 — with
GitHub Actions
Failure
ehaines1
had a problem deploying
to
Development
January 31, 2025 16:01 — with
GitHub Actions
Failure
ehaines1
had a problem deploying
to
Development
January 31, 2025 16:01 — with
GitHub Actions
Failure
ehaines1
had a problem deploying
to
Development
January 31, 2025 16:01 — with
GitHub Actions
Failure
ehaines1
had a problem deploying
to
Development
January 31, 2025 16:11 — with
GitHub Actions
Failure
ehaines1
had a problem deploying
to
Development
January 31, 2025 16:12 — with
GitHub Actions
Failure
ehaines1
had a problem deploying
to
Development
January 31, 2025 16:13 — with
GitHub Actions
Failure
ehaines1
had a problem deploying
to
Development
January 31, 2025 16:14 — with
GitHub Actions
Failure
Replaced by #1549 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR addresses a bug that existed when checking the policy 3.3 of Entra ID. We weren't checking if the Microsoft Authenticator was disabled. We also weren't checking the fields "isSoftwareOathEnabled" and the "includeTarget.id" fields of both "displayAppInformationRequiredState" and "displayLocationInformationRequiredState"
💭 Motivation and context
Closes #1484 and #1487
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist