Skip to content

feat(code/test): Dynamic validator set#987

Merged
romac merged 14 commits intomainfrom
bastien/dynamic-validator-set
May 6, 2025
Merged

feat(code/test): Dynamic validator set#987
romac merged 14 commits intomainfrom
bastien/dynamic-validator-set

Conversation

@bastienfaivre
Copy link
Copy Markdown
Contributor

@bastienfaivre bastienfaivre commented Apr 15, 2025

Closes: #944


PR author checklist

For all contributors

For external contributors

@bastienfaivre bastienfaivre marked this pull request as draft April 15, 2025 11:17
Comment thread code/crates/test/app/src/app.rs Outdated
Comment thread code/crates/test/app/src/app.rs Outdated
Comment thread code/crates/test/app/src/app.rs Outdated
Comment thread code/crates/test/app/src/app.rs Outdated
Comment thread code/crates/test/src/middleware.rs Outdated
Comment thread code/crates/test/src/middleware.rs Outdated
Comment thread code/crates/test/src/validator_set.rs Outdated
Comment thread code/crates/test/tests/it/validator_set.rs Outdated
Comment thread code/crates/test/tests/it/validator_set.rs
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (bbead49) to head (7816ea2).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #987   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bastienfaivre bastienfaivre marked this pull request as ready for review April 28, 2025 13:04
@bastienfaivre bastienfaivre requested a review from adizere as a code owner April 28, 2025 13:04
Comment thread docs/tutorials/channels.md Outdated
Copy link
Copy Markdown
Contributor

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @bastienfaivre!

@romac
Copy link
Copy Markdown
Contributor

romac commented May 6, 2025

Nice work! Can you please add entries in RELEASE_NOTE,md and in BREAKING_CHANGES.md? Then we can merge :)

@romac
Copy link
Copy Markdown
Contributor

romac commented May 6, 2025

Can you please add entries in RELEASE_NOTE,md and in BREAKING_CHANGES.md? Then we can merge :)

Nevermind, it's actually not necessary.

@romac romac enabled auto-merge May 6, 2025 08:49
@romac romac added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 93cfacd May 6, 2025
19 checks passed
@romac romac deleted the bastien/dynamic-validator-set branch May 6, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

code: Dynamic validator set

3 participants