Merged
Conversation
romac
requested changes
Apr 15, 2025
ancazamfir
reviewed
Apr 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
…ien/dynamic-validator-set
ancazamfir
reviewed
Apr 28, 2025
ancazamfir
approved these changes
Apr 28, 2025
Contributor
ancazamfir
left a comment
There was a problem hiding this comment.
Great work @bastienfaivre!
romac
approved these changes
May 6, 2025
Contributor
|
Nice work! Can you please add entries in RELEASE_NOTE,md and in BREAKING_CHANGES.md? Then we can merge :) |
Contributor
Nevermind, it's actually not necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #944
PR author checklist
For all contributors
RELEASE_NOTES.mdif the change warrants itBREAKING_CHANGES.mdif the change warrants itFor external contributors