Skip to content

Conversation

@christian-stephen
Copy link
Member

@christian-stephen christian-stephen commented May 21, 2025

⚙️ Issue

https://circleci.atlassian.net/browse/ONPREM-2408


⚙️ Change Description

New feature: This PR adds a new mode to orchestrator which will accept a custom entrypoint command and execute it, replacing the current process as PID 1. This command must be able to accept the command and args for GOAT and execute them, in order to run GOAT as a child process in addition to the custom entrypoint.

Acceptance Criteria:


Solution


Testing

  • Created and updated tests where applicable

📖 Documentation Updates

Comment on lines +62 to +64
if runtime.GOOS == "windows" {
t.Skip("Not supported on Windows")
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entrypoint override relies on exec for process replacement, so won't work on Windows for now.

@christian-stephen christian-stephen marked this pull request as ready for review October 16, 2025 10:48
@christian-stephen christian-stephen requested a review from a team as a code owner October 16, 2025 10:48
@christian-stephen christian-stephen changed the title Add entrypoint override [ONPREM-2408] Add entrypoint override Oct 16, 2025
@christian-stephen christian-stephen merged commit 9f7c3a3 into main Oct 21, 2025
9 checks passed
@christian-stephen christian-stephen deleted the cs/entrypoint branch October 21, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants