Feat/add pre commit hooks #12
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces pre-commit hooks and code quality tooling, updates development dependencies, and makes several minor code quality and correctness improvements. The main focus is on improving code consistency, enforcing linting standards, and fixing minor issues in file handling and exception raising.
Tooling and configuration:
.pre-commit-config.yamlto set up pre-commit hooks for YAML checks, whitespace fixes, and code linting/formatting with Ruff.pyproject.tomlto includepre-commitas a development dependency and added detailed Ruff configuration for linting and formatting, including target Python version and per-file ignores for tests. [1] [2]Code quality and correctness:
assert ValueError(...)withraise ValueError(...)incioos_metadata_conversion/erddap.pyfor proper error handling.Union[str, list]tostr | listfor modern Python type hinting incioos_metadata_conversion/erddap.py."r"mode fromopen()calls in several places, as"r"is the default mode. This improves code clarity incioos_metadata_conversion/record.pyandtests/test_datacite.py. [1] [2] [3] [4]Unionfromcioos_metadata_conversion/erddap.py.Other minor changes:
passstatement in the CLI definition incioos_metadata_conversion/__main__.py.