Add "getItems()" to Timeline #2028
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Would this be better if it returned a |
Contributor
Author
|
cool, thanks for the suggestion. I've fixed that and also made a sample app that shows how to inspect the items in the timeline here's a screen recording of the sample app: |
Collaborator
|
Looks good, though I'd propose we skip adding the sample to the official distribution (though it looks cool). I can cherry-pick the changes or if you'd rather not do a different PR. |
Contributor
Author
|
awesome! can you do the cherry pick? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently theres no way to retrieve all the items in the timeline, It would allow for some nice debug visualizations, like so
gist example:
https://gist.github.com/Hperigo/c635975c3a4fd7fbc62c782c99341f59