Consider use index for db search when it's in memory and search index is not #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 53ee404.
It might only make sense to do this when ENABLE_SEARCH_CACHE is enabled as an optimization. Otherwise, the search index is never in memory and the index likely is so the search indexes will never be used. Which might defeat the purpose
|
Implement the comment above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another alternative is to have them race and return the results from the index while the search cache is populated in the background.
So, if ENABLE_SEARCH_CACHE and the relevant index is in memory
The benefit of this is that we return the fastest result while the search cache is being populated (at which point, it would be the fastest result)