metrics: migrate Prometheus metrics to pkg/metrics helpers #4222
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AritraDey-Dev
force-pushed
the
metrics/migrate-to-helpers
branch
from
c61d544 to
ffae65b
Compare
AritraDey-Dev
force-pushed
the
metrics/migrate-to-helpers
branch
from
ffae65b to
6fadafc
Compare
|
Hey, could you wrap your commit description (use Also could the commit description contains more of the "why" of the change instead of the what (that should come from the title already), see more https://tetragon.io/docs/contribution-guide/submitting-a-pull-request/#write-a-commit-message. Thank you :) |
mtardy
added
the
release-note/misc
AritraDey-Dev
force-pushed
the
metrics/migrate-to-helpers
branch
from
6fadafc to
d8a3f92
Compare
There was a problem hiding this comment.
Thanks!
LGTM, but this is really tricky to review because to check for correctness, you need to check, for example, that the Inc() method uses the same type as the one we use to generate the constrained labels. I wonder if there is a way to avoid this duplication, but it's not obvious to me how.
AritraDey-Dev
force-pushed
the
metrics/migrate-to-helpers
branch
from
d8a3f92 to
a2a8c9b
Compare
The pkg/metrics helpers provide critical functionality that raw prometheus.New*Vec functions lack: automatic metric cleanup for deleted pods, cardinality constraints, configurable high-cardinality labels, and automatic documentation generation. Migrating to these helpers ensures consistent metric management across the codebase and prevents unbounded cardinality growth. Fixes cilium#2798 Signed-off-by: Aritra Dey <[email protected]>
AritraDey-Dev
force-pushed
the
metrics/migrate-to-helpers
branch
from
a2a8c9b to
2e3d8e3
Compare
3 participants
Fixes #2798
Description
This PR migrates Prometheus metrics to use pkg/metrics helpers.
Changelog