-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comment posting on failed CI run and cleanup benchmarks #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Post the comment showing the build & tests regardless of failure. Signed-off-by: Jussi Maki <[email protected]>
Drop the benchmarks for the 10k and 100k batch sizes. They're not providing further insights and use up fair bit of memory to execute. Signed-off-by: Jussi Maki <[email protected]>
BenchmarkDB_WriteTxn_100_SecondaryIndex was reconstructing the tags set on every insert which cost a bit of time and wasn't relevant for the benchmark. While at it simplify the batch benchmarks to not have two loops. Signed-off-by: Jussi Maki <[email protected]>
joamaki
requested review from
viktor-kurchenko and
dylandreimerink
and removed request for
a team
August 20, 2024 10:00
|
dylandreimerink
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PR fails the failed "make test" output wasn't posted. Add a "if: always()" to the comment posting to always post it.
This was manually tested.
Fix the secondary index benchmark not to recreate the tags set on each insert as that's not what is important for the benchmark.
Additionally drop the very large batch sizes from benchmarks as those use up fair bit of memory and don't provide a useful signal.