Add support for table initializers to gate keep pruning #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's often important to avoid pruning data before the table has been fully populated by writers. Add support for this in the form of table initializers that can be registered before the application starts. Make the reconciler pruning conditional on the table being fully initialized. The initializers are stored in the table entry, which means that the initializer count is coupled to the snapshot and thus a reader won't think the table is initialized before it gets a snapshot that indeed is initialized. Example: // Adding an initializer (called before start) txn := db.WriteTxn(myTable) done := myTable.RegisterInitializer(txn) txn.Commit() rtxn1 := db.ReadTxn() myTable.Initialized(rtxn1) == false txn = db.WriteTxn(myTable) done(txn) txn.Commit() rtxn2 := db.ReadTxn() myTable.Initialized(rtxn1) == false myTable.Initialized(rtxn2) == true Signed-off-by: Jussi Maki <[email protected]>
pippolo84
approved these changes
Mar 29, 2024
| // RegisterInitializer adds an initializers to the table. Returns | ||
| // a function to mark the initializer done. Once all initializers are | ||
| // done, Table[*].Initialized() will return true. | ||
| // This should only be used before the application has started. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's often important to avoid pruning data before the table has been fully populated by writers. Add support for this in the form of table initializers that can be registered before the application starts. Make the reconciler pruning conditional on the table being fully initialized.
The initializers are stored in the table entry, which means that the initializer count is coupled to the snapshot and thus a reader won't think the table is initialized before it gets a snapshot that indeed is initialized.
Example: