reconciler: Do not do WriteTxn on empty results

If the incremental round found no work to do we don't need to acquire the WriteTxn. This can happen when objects are updated but are not marked pending (e.g. changes are being made that do not need to be reconciled). Signed-off-by: Jussi Maki <[email protected]>
cilium · Apr 11, 2024 · 8c81916 · 8c81916
1 parent 33b817f
commit 8c81916
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/reconciler/incremental.go b/reconciler/incremental.go
@@ -262,6 +262,12 @@ func (round *incrementalRound[Obj]) processSingle(obj Obj, rev statedb.Revision,
 }
 
 func (round *incrementalRound[Obj]) commitStatus() <-chan struct{} {
+	if len(round.results) == 0 {
+		// Nothing to commit.
+		_, watch := round.table.All(round.txn)
+		return watch
+	}
+
 	wtxn := round.db.WriteTxn(round.table)
 	defer wtxn.Commit()