Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetect checklist template based on target version #298

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Feb 3, 2025

This allows the tool to autodetect the right template based on
the specified version rather than having to specify the path,
for example ./release --version v1.17.0.

@joestringer joestringer requested a review from aanm February 3, 2025 13:45
@joestringer joestringer marked this pull request as draft February 5, 2025 10:27
@joestringer joestringer force-pushed the pr/joe/embed-templates branch from da7d38a to d9bcded Compare February 17, 2025 20:24
This allows the tool to autodetect the right template based on
the specified version rather than having to specify the path,
for example `./release --version v1.17.0`.

Signed-off-by: Joe Stringer <[email protected]>
@joestringer joestringer force-pushed the pr/joe/embed-templates branch from d9bcded to 0258146 Compare February 17, 2025 20:25
@joestringer joestringer marked this pull request as ready for review February 17, 2025 20:26
@joestringer joestringer requested review from aanm and removed request for aanm February 17, 2025 20:26
@joestringer joestringer changed the title Embed release issue templates into the binary Autodetect checklist template based on target version Feb 17, 2025
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aanm aanm merged commit 3161e47 into main Feb 18, 2025
1 check passed
@aanm aanm deleted the pr/joe/embed-templates branch February 18, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants