Remove all newlines from changelog item output #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chance Zibolski <[email protected]>
Using bufio.Scanner handles \r\n and \n ensuring we don't leave \r in the JSON which results in invisible ^M characters in the output which is particularly annoying when storing result into a file. Signed-off-by: Chance Zibolski <[email protected]>
rolinh
approved these changes
Sep 27, 2024
aanm
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the changelog output so it removes both it handles both
\nand\r\n. I was finding that when I was outputting changelogs to a file, there were^Minvisible characters in the output. This is because the previous code was only replacing\nbut not the\r. When I query the GitHub API, newlines are typically delimited as\r\nso the code should accommodate this case.bufio.Scanneris designed to handle reading text line by line already, so I adapted thetextBlockBetweento usebuffo.Scannerwhile preserving existing behavior.