Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between label-filter and release labels #246

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Jul 24, 2024

Partially reverts the behavior change introduced by #238.

Filtering is still done in the changelog generation, but now we store all of the PR labels in the release-state and return to filtering against all the PR labels using --label-filter.

The newly introduced behavior in #238 is now part of the new --release-labels flag, which configures the release-labels to use when generating release notes.

CC @michi-covalent who noticed the behavior change.

This does require deleting your existing release-state.json since all PR labels are now being stored in the release-state.

(⎈|kind-kind:N/A) ~/p/w/cilium-oss ❯❯❯ GITHUB_TOKEN=$(gh auth token) /Users/chancez/projects/work/release/release changelog --base v1.16.0-pre.3 --head v1.16.0 --repo cilium/cilium --label-filter hubble-cli                                                                                                                                                                                                                  ✘ 127 main ✭
Comparing v1.16.0-pre.3...v1.16.0
Comparing v1.16.0-pre.3...369e927307d8780e0e6b5247d7e977bbd0fb8a05
Comparing v1.16.0-pre.3...a57393f33287cb65bd4be72c237a048ed457780f
Comparing v1.16.0-pre.3...deee47cac2f7c56d376e1877d1fb4bd9f3c9fd84
Comparing v1.16.0-pre.3...deee47cac2f7c56d376e1877d1fb4bd9f3c9fd84
Found 678 commits!
Preparing Changelog file  86% |██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████                                                    | (584/678, 3 it/s) [4m19s:33s]
WARNING: PR not found for commit 48a9976a09015a0e411997780c8b260d59593071!

Preparing Changelog file  86% |██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████                                                    | (585/678, 3 it/s) [4m19s:32s]
WARNING: PR not found for commit 568dbc5ad884e37614992f59ceb89ad89feb9135!

Preparing Changelog file 100% |███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| (678/678, 2 it/s)           

State stored successful in release-state.json, please use --state-file=release-state.json in the next run to continue

Found 319 PRs and 10 backport PRs!

Found 1 PRs and 0 backport PRs in release-state.json based on --label-filter

Summary of Changes                                                                                                                                                                                                                                                                                                                                                                                                                          
------------------

**Minor Changes:**
* hubble: node labels (cilium/cilium#32851, @kaworu)

@chancez chancez requested review from aanm and michi-covalent July 24, 2024 19:43
Partially reverts the behavior change introduced by
#238.

Filtering is still done in the changelog generation, but now we store
all of the PR labels in the release-state and return to filtering
against all the PR labels using --label-filter.

The newly introduced behavior in #238 is now part of the new
--release-labels flag, which configures the release-labels to use when
generating release notes.

Signed-off-by: Chance Zibolski <[email protected]>
@chancez chancez force-pushed the pr/chancez/release_vs_filter_labels branch from fd6045e to 928899c Compare July 24, 2024 19:49
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 👍

@joestringer joestringer merged commit e6967d5 into main Jul 25, 2024
1 check passed
@joestringer joestringer deleted the pr/chancez/release_vs_filter_labels branch July 25, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants