Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm: Upgrade to LLVM 17.0.6 #267

Merged
merged 1 commit into from
Apr 10, 2024
Merged

llvm: Upgrade to LLVM 17.0.6 #267

merged 1 commit into from
Apr 10, 2024

Conversation

gentoo-root
Copy link
Contributor

@gentoo-root gentoo-root commented Mar 27, 2024

Fixes for Clang 17 were merged into the Cilium codebase:

b91046955d6b ("datapath: Ignore new debug ELF prefixes")
6e18eb020b68 ("bpf: Fix compatibility with Clang 17 in __lb6_affinity_backend_id")
3740e9db8fef ("bpf: Fix "R2 !read_ok" verifier error with LLVM 17")
c6fe6b8e2546 ("bpf/tests: Fix conntrack_test.c in prep for Clang update")
4dd6b0a4f97f ("bpf/tests: Fix undefined behavior in memcmp MAC addresses")
f87b5dc5e0b2 ("bpf/tests: Fix undefined behavior in EXPECTED_DEST_MAC")

and the complexity measurements were performed, so now the LLVM image can be upgraded.

@gentoo-root gentoo-root requested a review from a team as a code owner March 27, 2024 20:01
@gentoo-root gentoo-root requested a review from rgo3 March 27, 2024 20:01
@gentoo-root gentoo-root force-pushed the pr/max/upgrade-llvm-17 branch from 5006eb5 to 22687a2 Compare March 27, 2024 23:01
@gentoo-root gentoo-root marked this pull request as draft March 28, 2024 08:48
Copy link

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:tearsofjoy:

@gentoo-root gentoo-root marked this pull request as ready for review April 10, 2024 11:05
@gentoo-root gentoo-root marked this pull request as draft April 10, 2024 11:05
Fixes for Clang 17 were merged into the Cilium codebase:

b91046955d6b ("datapath: Ignore new debug ELF prefixes")
6e18eb020b68 ("bpf: Fix compatibility with Clang 17 in __lb6_affinity_backend_id")
3740e9db8fef ("bpf: Fix "R2 !read_ok" verifier error with LLVM 17")
c6fe6b8e2546 ("bpf/tests: Fix `conntrack_test.c` in prep for Clang update")
4dd6b0a4f97f ("bpf/tests: Fix undefined behavior in memcmp MAC addresses")
f87b5dc5e0b2 ("bpf/tests: Fix undefined behavior in EXPECTED_DEST_MAC")

and the complexity measurements were performed, so now the LLVM image
can be upgraded.

Signed-off-by: Maxim Mikityanskiy <[email protected]>
@gentoo-root gentoo-root force-pushed the pr/max/upgrade-llvm-17 branch from 22687a2 to 5f1b853 Compare April 10, 2024 15:37
@gentoo-root gentoo-root marked this pull request as ready for review April 10, 2024 15:38
@borkmann borkmann merged commit 6fd8e1b into master Apr 10, 2024
2 checks passed
@borkmann borkmann deleted the pr/max/upgrade-llvm-17 branch April 10, 2024 18:49
@julianwiedmann
Copy link
Member

julianwiedmann commented Oct 21, 2024

@gentoo-root should we also update the required LLVM version in https://docs.cilium.io/en/stable/operations/system_requirements/ ? Given that we no longer test with v10.0, I'm rather skeptical how well Cilium would still work with such older version ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants