Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observe: Support -f and --first at the same time #1010

Closed
wants to merge 1 commit into from
Closed

observe: Support -f and --first at the same time #1010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cmd/observe/flows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,9 +616,6 @@ func getFlowsRequest(ofilter *flowFilter, allowlist []string, denylist []string)
if first && selectorOpts.all {
return nil, fmt.Errorf("cannot set both --first and --all")
}
if first && selectorOpts.follow {
return nil, fmt.Errorf("cannot set both --first and --follow")
}
Comment on lines -619 to -621
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: removing this check is fine, the Hubble server currently does the same validation on the gRPC request object, and thus we'll still get an error if the server doesn't support combining --first and --follow.

if last && selectorOpts.all {
return nil, fmt.Errorf("cannot set both --last and --all")
}
Expand Down