Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating home namespace list, enhancing the UI. #936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pedroignacio13
Copy link

@pedroignacio13 pedroignacio13 commented Oct 14, 2024

On Hubble's main page, I changed the way the namespace's list appear under the "To begin select one of the namespaces:" text.
The namespaces are being shown using the Dropdown list Hubble uses on the top of the UI.
In the main page, the dropdown list will only appear in the middle of the screen, not anymore in the top portion of it.
After selecting a namespace and being redirected to the "flows" page, the list will reappear on the top.

Before After
image image

@pedroignacio13 pedroignacio13 requested a review from a team as a code owner October 14, 2024 03:03
@pedroignacio13 pedroignacio13 requested review from geakstr and removed request for a team October 14, 2024 03:03
Copy link
Collaborator

@geakstr geakstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution!

@geakstr
Copy link
Collaborator

geakstr commented Oct 28, 2024

@pedroignacio13 please update failed e2e test to pass CI

@pedroignacio13
Copy link
Author

@pedroignacio13 please update failed e2e test to pass CI

Hi @geakstr, I've been updating some of the tests but believe to have something wrong with them.
Are you on Slack? I'd like to ask you some questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants