Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate blueprint MultiSelect2 #846

Merged

Conversation

yannikmesserli
Copy link
Contributor

Summary

Migrate the deprecated MultiSelect2 to MultiSelect.

Changes

  • Change MultiSelect2 to MultiSelect

Screenshots

Screenshot 2024-04-18 at 10 37 09
Screenshot 2024-04-18 at 10 36 38

Unit tests

n/a

Functional tests

  • Open Hubble UI and select a namespace
  • Observe that the filter input looks good in the top bar
  • Click on a service card
  • Check that the labels are still well rendered in the top bar

@yannikmesserli yannikmesserli requested a review from a team as a code owner April 18, 2024 08:39
@yannikmesserli yannikmesserli requested review from kimstacy and removed request for a team April 18, 2024 08:39
@yannikmesserli yannikmesserli added this to the v0.13.2 milestone Jan 13, 2025
@yannikmesserli yannikmesserli force-pushed the pr/yannik/migrate-blueprint-select branch from 0b29bad to 4c75c64 Compare January 13, 2025 17:15
@yannikmesserli yannikmesserli force-pushed the pr/yannik/migrate-blueprint-select branch from 4c75c64 to 4ec5def Compare February 10, 2025 14:06
@yannikmesserli yannikmesserli requested review from geakstr and removed request for kimstacy February 10, 2025 14:06
@yannikmesserli yannikmesserli self-assigned this Feb 10, 2025
@geakstr geakstr merged commit 0ffae8a into cilium:master Feb 10, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants