Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile to use NODE_ENV=development #687

Closed
wants to merge 1 commit into from
Closed

Update Dockerfile to use NODE_ENV=development #687

wants to merge 1 commit into from

Conversation

kimstacy
Copy link
Member

@kimstacy kimstacy commented Oct 17, 2023 •
edited
Loading

Previously, the build-and-push-prs jobs would fail with the error:

ERROR: failed to solve: process "/bin/sh -c npm --target_arch=${TARGETARCH} install" did not complete successfully: exit code: 1
Error: buildx failed with: ERROR: failed to solve: process "/bin/sh -c npm --target_arch=${TARGETARCH} install" did not complete successfully: exit code: 1

This resolves the issue by altering the Dockerfile and setting the Node environment to a development environment when running npm install against the target architecture. We achieve this by adding to NODE_ENV=development to RUN npm --target_arch=${TARGETARCH} install.

The result? 🪄

RUN NODE_ENV=development npm --target_arch=${TARGETARCH} install

@kimstacy
Update Dockerfile to use NODE_ENV=development
7ee8fae 
This sets the Node environment to a development environment when running
`npm install` against the target architecture.

Signed-off-by: Stacy Kim <[email protected]>
@kimstacy kimstacy marked this pull request as ready for review October 17, 2023 04:55
@kimstacy kimstacy requested a review from a team as a code owner October 17, 2023 04:55
@kimstacy kimstacy requested review from yandzee and removed request for a team October 17, 2023 04:55
@kimstacy kimstacy added the release-note/misc Changes without direct user impact label Oct 17, 2023
@kimstacy
Copy link
Member Author

Closing as this was unnecessary.

@kimstacy kimstacy closed this Oct 18, 2023
@kimstacy kimstacy deleted the pr/stacy/fix-docker-buildx-error branch October 19, 2023 06:43
@kimstacy kimstacy added invalid This doesn't seem right and removed release-note/misc Changes without direct user impact labels Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yandzee yandzee Awaiting requested review from yandzee yandzee is a code owner automatically assigned from cilium/hubble-ui

Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kimstacy