Skip to content

Commit

Permalink
backend/internal/config: log env var fallback as info instead of warning
Browse files Browse the repository at this point in the history
The cilium-cli connectivity test treats warnings in the logs as test
errors[^1]. This causes tests involving hubble-ui to fail[^2]. As
these fallbacks aren't really warnings but rather
informative messsages, demote them to info level.

[^1]: cilium/cilium#35723
[^2]: https://github.com/cilium/cilium-cli/actions/runs/12051244564/job/33601849065?pr=2869#step:13:541

Signed-off-by: Tobias Klauser <[email protected]>
  • Loading branch information
tklauser committed Nov 28, 2024
1 parent a06e19b commit cd2ee5b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion backend/internal/config/prop_getters.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,5 +181,5 @@ func (er *EnvVarResult[T]) LogIfFallback(log logrus.FieldLogger) {
log.
WithField("var", er.VarName).
WithField("fallback", fmt.Sprintf("%v", er.Value)).
Warn("using fallback value for env var")
Info("using fallback value for env var")
}

0 comments on commit cd2ee5b

Please sign in to comment.