doc: fixed latest binary installation steps #3142
Conversation
The one here was causing this error
```bash
❯ sha256sum --check cilium-${GOOS}-${GOARCH}.tar.gz.sha256sum
sha256sum: cilium--.tar.gz.sha256sum: no properly formatted SHA256 checksum lines found
❯ sudo tar -C /usr/local/bin -xzvf cilium-${GOOS}-${GOARCH}.tar.gz
rm cilium-${GOOS}-${GOARCH}.tar.gz{,.sha256sum}
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting no
```
replaced with the one from the docs, which works
Signed-off-by: Ashu Pednekar <[email protected]>
| CLI_ARCH=amd64 | ||
| if [ "$(uname -m)" = "aarch64" ]; then CLI_ARCH=arm64; fi | ||
| curl -L --fail --remote-name-all https://github.com/cilium/cilium-cli/releases/download/${CILIUM_CLI_VERSION}/cilium-linux-${CLI_ARCH}.tar.gz{,.sha256sum} | ||
| sha256sum --check cilium-linux-${CLI_ARCH}.tar.gz.sha256sum | ||
| sudo tar xzvfC cilium-linux-${CLI_ARCH}.tar.gz /usr/local/bin | ||
| rm cilium-linux-${CLI_ARCH}.tar.gz{,.sha256sum} |
There was a problem hiding this comment.
This now hard-codes linux. Maybe it's better to replace this section entirely with a link to the docs which have installation instructions for all supported operating systems?
There was a problem hiding this comment.
The docs page also has additional instructions pertaining target k8s distro
Copied the Mac OS commands as well, other anyway points to GitHub releases
There was a problem hiding this comment.
I think it would still be good to link to the installation docs, so we habe a single source of truth.
| See https://github.com/cilium/cilium-cli/releases for supported `GOOS`/`GOARCH` | ||
| binary releases. |
There was a problem hiding this comment.
This is now no longer accurate as the script above no longer uses GOOS/GOARCH.
|
Commit 6d42bf2 does not match "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
2 participants
The one here was causing this error
replaced with the one from the docs, which works