-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Protocol-defined neural network inference #99
Draft
gwennlbh
wants to merge
7
commits into
sidepanelredesign
Choose a base branch
from
protocoldefinedmodels
base: sidepanelredesign
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+353
−609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1460930
to
3040ca0
Compare
70266d2
to
5ffa91b
Compare
ae8da13
to
ba146bb
Compare
ba146bb
to
de94a7d
Compare
de94a7d
to
9441385
Compare
9441385
to
91690b6
Compare
91690b6
to
72f4511
Compare
72f4511
to
650dfd0
Compare
650dfd0
to
3125fe0
Compare
gwennlbh
commented
Mar 22, 2025
…nstead of enforcing it Otherwise we can't generate the JSON schema, since the .filter() is not serializable
Loading status checks…
…op box
3101252
to
7abd9cf
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started something, but this probably needs a discussion with @edgaremy and @axelcarlier before settling on the data we ask to protocol definitions
The end-goal here is possibly to get rid of built-in metadata and protocols all together (or at least making the built-in "default" protocol a regular protocol defined in a .yaml file)
this potentially requires a lot of de-harcoding in a codebase but i think it's worth it, especially since i suppose the neural net (espeically on the classification part) will improve over time and potentially grow with more classes
This PR targets the sidepanelredesign branch that contains taxonomy tree changes (see #95), since classification logic, species metadata definition and taxonomic inference are deeply intertwined.
TODO:
cx
/cy
instead of sx/sy. Currently we act as if sx=cx and sy=cy (or the reverse, can't remember)