Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Protocol-defined neural network inference #99

Draft
wants to merge 7 commits into
base: sidepanelredesign
Choose a base branch
from

Conversation

gwennlbh
Copy link
Member

@gwennlbh gwennlbh commented Mar 16, 2025

I've started something, but this probably needs a discussion with @edgaremy and @axelcarlier before settling on the data we ask to protocol definitions

The end-goal here is possibly to get rid of built-in metadata and protocols all together (or at least making the built-in "default" protocol a regular protocol defined in a .yaml file)

this potentially requires a lot of de-harcoding in a codebase but i think it's worth it, especially since i suppose the neural net (espeically on the classification part) will improve over time and potentially grow with more classes

This PR targets the sidepanelredesign branch that contains taxonomy tree changes (see #95), since classification logic, species metadata definition and taxonomic inference are deeply intertwined.

TODO:

  • Take into account that output detection shape can have cx/ cy instead of sx/sy. Currently we act as if sx=cx and sy=cy (or the reverse, can't remember)
  • Allow specifying ex/ey instead of w/h (end x and end y)
  • Figure out what our model really has as data instead of w and h (theres a weird w | x w | and similarily for h, w & h are probably ex and ey in our case instead)
  • Take into account output.normalized et input.normalized dans tout les cas
  • Take into account input.disposition in all cases

Sorry, something went wrong.

Copy link

github-actions bot commented Mar 16, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://cigaleapp.github.io/cigale/_pullrequests/pr-99/

Built to branch gh-pages at 2025-03-22 02:41 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@gwennlbh gwennlbh mentioned this pull request Mar 16, 2025
@gwennlbh gwennlbh force-pushed the protocoldefinedmodels branch from 1460930 to 3040ca0 Compare March 17, 2025 10:02
@gwennlbh gwennlbh force-pushed the taxonomytree branch 2 times, most recently from 70266d2 to 5ffa91b Compare March 21, 2025 12:49
@gwennlbh gwennlbh force-pushed the protocoldefinedmodels branch 2 times, most recently from ae8da13 to ba146bb Compare March 21, 2025 12:53
@gwennlbh gwennlbh changed the base branch from taxonomytree to sidepanelredesign March 21, 2025 13:09
@gwennlbh gwennlbh force-pushed the protocoldefinedmodels branch from ba146bb to de94a7d Compare March 21, 2025 13:09
@gwennlbh gwennlbh force-pushed the protocoldefinedmodels branch from de94a7d to 9441385 Compare March 21, 2025 15:04
@gwennlbh gwennlbh force-pushed the protocoldefinedmodels branch from 9441385 to 91690b6 Compare March 21, 2025 15:05
@gwennlbh gwennlbh force-pushed the protocoldefinedmodels branch from 91690b6 to 72f4511 Compare March 21, 2025 19:59
@gwennlbh gwennlbh force-pushed the protocoldefinedmodels branch from 72f4511 to 650dfd0 Compare March 22, 2025 00:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@gwennlbh gwennlbh force-pushed the protocoldefinedmodels branch from 3101252 to 7abd9cf Compare March 22, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant