simplifying logic, same output.

cidgoh · Dec 12, 2024 · 8e2c207 · 8e2c207
1 parent 430949c
commit 8e2c207
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/lib/Validator.js b/lib/Validator.js
@@ -236,20 +236,17 @@ class Validator {
     );
 
     const validate = (value) => {
-      if (slotDefinition.required && !value) {
-        return 'This field is required';
-      }
-
-      if (slotDefinition.value_presence === 'PRESENT' && !value) {
-        return 'Value is not present';
-      } else if (slotDefinition.value_presence === 'ABSENT' && value) {
-        return 'Value is not absent';
-      }
-
       if (!value) {
+        if (slotDefinition.required) 
+          return 'This field is required';
+        if (slotDefinition.value_presence === 'PRESENT')
+          return 'Value is not present';
         return;
       }
 
+      if (slotDefinition.value_presence === 'ABSENT')
+        return 'Value is not absent';
+
       let splitValues;
       if (slotDefinition.multivalued) {
         splitValues = value.split(this.#multivaluedDelimiter);