-
Notifications
You must be signed in to change notification settings - Fork 378
Improve addon typing #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkszepp
wants to merge
85
commits into
master
Choose a base branch
from
improve-typescript-story
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve addon typing #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 24, 2025
…y components & fix some types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This changes are breaking for current app's and right now not complete
ToDo's
anytypesmultipleas paramter@extrato every component (gives user a simple possibility to pass custom values)Breaking changes:
componentas strings was removed. Since ember 3.25 its recommended to pass component instead string. The@embroider/utilpackage is deprecated<PowerSelectMultipleInputField>was removed => If this was used in app, you can use now<PowerSelectInputField>and replace@placeholderparamenter with@searchPlaceholder(deprecation added in 8.11)ember-power-select-trigger-multiple-input-*toember-power-select-trigger-input-*(its equal to single) (deprecation added in 8.11)<PowerSelectMultipleTrigger>was removed => If this was used in app, you can use now<PowerSelectTrigger>(deprecation added in 8.11)<PowerSelectMultiple>is now a wrapper component (it has no logic, it pass only@multiple={{true}}to<PowerSelect>component (deprecation added in 8.11)types.ts(possible breaking)undefinedinsteadnull(there is now nonullanymore). This means, that the selected type is nowT | undefinedand not anymoreT | null | undefined