This repository was archived by the owner on Jul 16, 2020. It is now read-only.
travis: Fail build on go vet, golint or misspell errors #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go vet is run on all packages except for ciao-controller which currently contains a go vet error. Once this is fixed we'll update the travis.yml file to vet this package as well. The following packages are excluded from golint runs as they too contain errors: - github.com/01org/ciao/ciao-cli - github.com/01org/ciao/ciao-controller/internal/datastore - github.com/01org/ciao/ciao-controller/types golint is disabled on tip for the time being. It seems to be panicking. Signed-off-by: Mark Ryan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go vet is run on all packages except for ciao-controller which currently
contains a go vet error. Once this is fixed we'll update the travis.yml
file to vet this package as well.
The following packages are excluded from golint runs as they too contain
errors:
golint is disabled on tip for the time being. It seems to be panicking.
Signed-off-by: Mark Ryan [email protected]