New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add simple support for pending and skipped steps in spinach #4

Open

JohnBat26 wants to merge 2 commits into ci-reporter:master from JohnBat26:add_skipped_steps

JohnBat26 commented Jun 17, 2014

No description provided.

JohnBat26 added 2 commits

June 17, 2014 19:31


          add simple support for pending and skipped steps in spinach

f82663a


          remove on_skipped_step

61c4adf

Member

shepmaster commented Jun 22, 2014

Thanks for the PR!

I cannot accept it as-is however:

You say that this adds support for both pending and skipped, but the commit only adds code for pending. Your messages and code need to be consistent.
You will also need to add tests for the new cases you want to support.

Let me know how we can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet