Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed instructions for current rails version #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bluehallu
Copy link

minitest task doesn't exist anymore, hook into rake test directly does work.

minitest task doesn't exist anymore, hook into rake test directly does work.
@shepmaster
Copy link
Member

Thanks for your contribution!

CI::Reporter is designed to be used with any Ruby project, not just ones using Rails. As such, the project may create a Rake task with whatever name they choose. Our intent was that the text Rake code that creates a task called :minitest in the README would indicate that.

Do you have a suggestion for how to make this more clear, without picking another static name that will confuse a different person?

@bluehallu
Copy link
Author

I see your point, I'd probably explicitly say in the instructions that for rails that's what you need to call as I imagine that's the most popular use case for minitest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants