add MonthsDelta #859
Closed
add MonthsDelta #859
+108
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esheppa
force-pushed
the
add-month-delta
branch
from
748e154 to
5a0b93f
Compare
djc
reviewed
Nov 2, 2022
| /// MonthsDelta::Backwards(Months::new(13)) | ||
| /// ); | ||
| /// ``` | ||
| pub fn months_since(self, rhs: NaiveDate) -> MonthsDelta { |
There was a problem hiding this comment.
So what was the use case for adding this?
There was a problem hiding this comment.
This is mainly for API consistency, we have Duration and TimeDelta, Days and DateDelta and here Months and MonthsDelta.
Calculating the calendar months between two dates is often useful in financial / accounting style calculations, but it is admittedly a narrow use case, and could be better served in an external library
There was a problem hiding this comment.
Unless you have a concrete use case for this in the near future, I would propose that we leave this out for now. We already have a lot to work through in this crate, so better not to add more code unless we have a somewhat strong proof that we need/want it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been separated out from #824