This repository has been archived by the owner on Aug 3, 2022. It is now read-only.
Support reading DNS settings from NetworkManager on Linux #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support reading DNS settings from NetworkManager on Linux. Call nmcli-tool to get the DNS settings. On Ubuntu 12.04, NetworkManager is setup by default to run dnsmasq on 127.0.0.1:53. This causes reading the DNS server from /etc/resolv.conf to return that address, which will not work as an address for webpage-replay to use. Does not support setting the DNS, as dnsmasq is most likely listening on 127.0.0.1:53. Thus, this fixes problems only for --no-dns_forwarding use-cases.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support reading DNS settings from NetworkManager on Linux. Call
nmcli-tool to get the DNS settings.
On Ubuntu 12.04, NetworkManager is setup by default to run dnsmasq on
127.0.0.1:53. This causes reading the DNS server from /etc/resolv.conf
to return that address, which will not work as an address for
webpage-replay to use.
Does not support setting the DNS, as dnsmasq is most likely listening on
127.0.0.1:53. Thus, this fixes problems only for --no-dns_forwarding
use-cases.