-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests that rely on behavior of external domains #112
Comments
(See also issue #75) |
I drafted a fix for this a while back! I'll go dust it off. |
That sounds incredibly useful, even if it's only partially complete. |
Here's the part I was able to dig up: d4e2a71 The idea was to have a JSON file mapping URLs to I have to apologize for the state of the code, though. It's even more incomplete than I remember, and I don't have time to work on it right now. It should give you a rough idea how how to hook up a custom transport for testing, though. |
At the moment this test looks dead in the water and probably won't be moved foward due to bandwidth. I could dig and figure it out but I think fixing Chromium bugs is out of scope. I've removed the failing test for now. Please see chromium/hstspreload#112 for further info.
These tests should be fixed (chromium#112); in the meantime disable them so that `make test` passes.
These tests should be fixed (chromium#112); in the meantime disable them so that `make test` passes.
These tests should be fixed (#112); in the meantime disable them so that `make test` passes.
Like PR chromium#131, these tests should be fixed as part of issue chromium#112, but in the meantime disabling them so that `make test` passes.
Some of the test cases in redirects_test.go and domain_test.go rely on the behavior of external domains. For some of these tests, that behavior has changed and the tests are no longer passing.
Preferably, the tests would be hermetic and not connect to any external sites. If that's not possible, I'd prefer restricting it to domains where we have some reasonable assurance that it will keep behaving the way we expect for a test (e.g. badssl.com).
The text was updated successfully, but these errors were encountered: