Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.10] Update PHPUnit configuration #551

Closed

Conversation

osbre
Copy link
Contributor

@osbre osbre commented Oct 1, 2023

There was 1 PHPUnit test runner deprecation:

1) Your XML configuration validates against a deprecated schema. Migrate your XML configuration using "--migrate-configuration"!

@GrahamCampbell
Copy link
Member

I think this breaks coverage on phpunit 9 though?

@osbre
Copy link
Contributor Author

osbre commented Oct 1, 2023

Tested with PHPUnit 9 - all tests passed but adds one more warning to the beginning of the output:

Line 9:
 - Element 'source': This element is not expected.

Test results may not be as expected.

If I run the tests before this change with PHPUnit 9, it always shows this warning:

Line 2:

- Element 'phpunit', attribute 'requireCoverageMetadata': The attribute 'requireCoverageMetadata' is not allowed.

Test results may not be as expected.

So, it works but adds one more warning.

¯\_(ツ)_/¯

@GrahamCampbell
Copy link
Member

Warning is worse than deprecation. ;)

deprecation < warning < error.

@GrahamCampbell
Copy link
Member

There is more than just a warning there FYI, it is actually broken in loading the source for coverage.

@osbre
Copy link
Contributor Author

osbre commented Oct 1, 2023

Sorry, indeed, I missed the part about coverage 👀

@osbre osbre deleted the fix/phpunit-deprecated-configuration branch October 1, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants